Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make getCacheIdentifier config property asynchronous #2266

Conversation

ing-athirlwall
Copy link
Contributor

@ing-athirlwall ing-athirlwall commented Apr 18, 2024

What I did

  1. Make the getCacheItentifier function asynchronous. This would make the Lion Ajax library compatible with using the profilesReady function which retrieves the profiles within the Enhanced WebView.

Copy link

changeset-bot bot commented Apr 18, 2024

🦋 Changeset detected

Latest commit: c6ac80e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lion/ajax Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Apr 18, 2024

CLA assistant check
All committers have signed the CLA.

@ing-athirlwall ing-athirlwall marked this pull request as draft April 30, 2024 12:38
@ing-athirlwall ing-athirlwall force-pushed the feat/make-get-cache-interceptor-asynchronous branch 2 times, most recently from 8d829ae to 486ca8f Compare May 7, 2024 07:37
@tlouisse tlouisse marked this pull request as ready for review May 7, 2024 08:24
@tlouisse tlouisse self-requested a review May 7, 2024 08:25
@ing-athirlwall ing-athirlwall force-pushed the feat/make-get-cache-interceptor-asynchronous branch from 486ca8f to fcc136f Compare May 7, 2024 08:41
@ing-athirlwall ing-athirlwall force-pushed the feat/make-get-cache-interceptor-asynchronous branch from fcc136f to c6ac80e Compare May 7, 2024 10:03
@tlouisse tlouisse merged commit c5ffe9c into ing-bank:master May 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants